This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(slack): log warning instead of throwing exception when user posts to main triage channel thread #6050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to main triage channel thread
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Slack integration by logging a warning instead of throwing an exception when multiple conversations are found for a given channel and thread combination. Key changes include new tests for various conversation retrieval scenarios and updated fallback logic in the get_by_channel_id_ignoring_channel_type service function to log a warning when multiple conversations are found.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/conversation/test_conversation_service.py | Added comprehensive tests for conversation retrieval logic under various channel/thread conditions. |
| src/dispatch/conversation/service.py | Modified fallback logic to log a warning (instead of throwing an exception) when multiple conversations are found. |
…in-channel-thread
whitdog47
changed the title
…in-channel-thread
…thread' of https://github.com/Netflix/dispatch into fix/multiple-conversation-when-posting-in-main-channel-thread
aaronherman
approved these changes
Jun 11, 2025
…in-channel-thread
whitdog47
deleted the
fix/multiple-conversation-when-posting-in-main-channel-thread
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Slack integration by logging a warning instead of throwing an exception when multiple conversations are found for a given channel and thread combination. Key changes include new tests for various conversation retrieval scenarios and updated fallback logic in the
get_by_channel_id_ignoring_channel_typeservice function to log a warning when multiple conversations are found.