This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(slack): ensures we don't exceed 3000 limit #6049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where Slack messages may exceed Block Kit's 3000-character limit by truncating the message text appropriately. Key changes include:
- Modifying the message truncation logic to include a header and ensure the overall text (with header) remains within limits.
- Updating the pre-commit configuration to use the "pre-push" stage instead of "push".
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/dispatch/plugins/dispatch_slack/case/messages.py | Updates truncation logic to prepend a header and limit text length to 3000 characters. |
| .pre-commit-config.yaml | Changes stage from "push" to "pre-push" for the pytest hook. |
aaronherman
approved these changes
Jun 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.