This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(entity_type): send channel notification once #6048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Whittaker <84562015+whitdog47@users.noreply.github.com>
aaronherman
approved these changes
Jun 10, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the entity update notification so it’s sent only once per batch rather than per signal instance, reducing duplicate messages.
- Move notification send logic from the flow to the view’s batch handler
- Remove per-instance notification and related imports from
flows.py - Add logging around the notification call to catch failures
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dispatch/entity_type/views.py | Send notification once after processing all signal instances |
| src/dispatch/entity_type/flows.py | Remove per-instance notification logic and unused imports |
Comments suppressed due to low confidence (1)
src/dispatch/entity_type/views.py:120
- Add a unit or integration test to confirm that the notification is sent exactly once for multiple signal instances, and that it’s not sent when no instances are updated.
send_entity_update_notification(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the entity_type notification was being repeatedly sent in the channel due to multiple signal instances in one case.