This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(cases): use separate email template for cases #6022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR separates case-specific welcome emails from incident ones by introducing a new case_welcome template type and updating all related code paths, UI, and tests.
- Added a new
case_welcomeenum and renamed the oldwelcometoincident_welcome - Updated factories, messaging, and case flows to use the new
caseWelcometemplate - Extended the Vue form to let users choose between incident and case welcome emails
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/factories.py | Updated default factory type to incident_welcome |
| src/dispatch/email_templates/enums.py | Added case_welcome and renamed welcome to incident_welcome |
| src/dispatch/static/dispatch/src/email_templates/NewEditSheet.vue | Updated dropdown items and hint text for case/incident |
| src/dispatch/incident/messaging.py | Changed lookup to use incident_welcome |
| src/dispatch/case/flows.py | Changed lookups to use case_welcome and tweaked logging |
wssheldon
approved these changes
May 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates case-specific welcome emails from incident ones by introducing a new
case_welcometemplate type and updating all related code paths, UI, and tests.case_welcomeenum and renamed the old welcome toincident_welcome