This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix: slack plugin activity fetch #6000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the slack plugin activity fetch functionality by streamlining the fetch_events method.
- Simplifies the function signature and docstring.
- Removes redundant event type checking and changes exception handling.
Comments suppressed due to low confidence (1)
src/dispatch/plugins/dispatch_slack/plugin.py:437
- The checks for event being None or a type have been removed. Ensure that event will always be a valid object with a fetch_activity method before invoking it.
activity = event.fetch_activity(client, subject, oldest)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
mvilanova
reviewed
May 20, 2025
mvilanova
reviewed
May 20, 2025
Co-authored-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com> Signed-off-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
mvilanova
approved these changes
May 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.