This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(ai): use subquery instead of from_self #5994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the case query mechanism in the AI service to replace the deprecated from_self() function with an explicit subquery and alias approach. The changes ensure compatibility with SQLAlchemy 2.0 while maintaining the functionality of filtering related cases.
- Replaces from_self() with a subquery and aliased model for filtering.
- Updates import statements to include aliased from SQLAlchemy.
Comments suppressed due to low confidence (1)
src/dispatch/ai/service.py:155
- Verify that the new subquery aliasing and filtering logic exactly replicates the intended behavior of the original query, as differences in query execution might have unexpected consequences.
related_cases.extend(db_session.query(case_alias).filter(case_alias.id != case.id).all())
wssheldon
approved these changes
May 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the case query mechanism in the AI service to replace the deprecated from_self() function with an explicit subquery and alias approach. The changes ensure compatibility with SQLAlchemy 2.0 while maintaining the functionality of filtering related cases.