This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(ui): fixes participant lint error #5990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a lint error related to variable naming in the participant search popover component. It updates the iteration variable in the v-for loop and adjusts associated references accordingly.
- Renames iteration variable from "participant" to "part".
- Updates event handlers and template bindings to use the new variable name.
Comments suppressed due to low confidence (1)
src/dispatch/static/dispatch/src/participant/ParticipantSearchPopover.vue:298
- [nitpick] Renaming the iteration variable to 'part' reduces clarity. Consider renaming it to a more descriptive name like 'participant' if it does not conflict with linting rules.
v-for="(part, index) in filteredParticipants"
wssheldon
approved these changes
May 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a lint error related to duplicate variable naming in the participant search popover component. It updates the iteration variable in the v-for loop and adjusts associated references accordingly.