Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@mvilanova
Copy link
Contributor

…ity error on delete

@mvilanova mvilanova requested review from Copilot and whitdog47 May 19, 2025 22:07
@mvilanova mvilanova self-assigned this May 19, 2025
@mvilanova mvilanova added the bug Something isn't working label May 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates error messages in the oncall service views to provide more descriptive and context-specific feedback when operations fail, particularly focusing on handling integrity errors during deletion.

  • Updated error messages to reference "oncall service" instead of a generic "service".
  • Reordered imports and updated the imported functions list.
Comments suppressed due to low confidence (1)

src/dispatch/service/views.py:8

  • The 'delete' function is used in the delete_service function (line 117) but is no longer imported from .service. Please add 'delete' to the import list to ensure deletion works as expected.
from .service import ( get, get_all_by_external_ids, get_by_external_id_and_project_name, update, )

@whitdog47 whitdog47 merged commit f33a721 into main May 19, 2025
10 checks passed
@whitdog47 whitdog47 deleted the fix/oncall-service-delete branch May 19, 2025 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants