This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(slack): fixing initial value for notification group update #5987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
approved these changes
May 19, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue in the Slack notifications plugin by fixing the initial value for notification group updates.
- Removed an unnecessary blank line.
- Updated the PlainTextInput component to conditionally set its initial_value based on available member data.
- Modified the submission event handler to correctly derive current_members when no initial_value is provided.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the Slack notifications plugin by fixing the initial value for notification group updates.