This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(slack): convert ids back from string to int #5981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR converts various IDs from strings back to integers for Slack-related incident and case interactions.
- Convert project, incident, case, and other ID values using int() to ensure proper type handling.
- Applies similar changes across both incident and case interactive modules.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/dispatch/plugins/dispatch_slack/incident/interactive.py | Wraps multiple context ID accesses with int() conversions for incident flows. |
| src/dispatch/plugins/dispatch_slack/case/interactive.py | Applies int() conversion for case IDs and project IDs to restore type consistency. |
wssheldon
approved these changes
May 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts various IDs from strings back to integers for Slack-related incident and case interactions.
Convert project, incident, case, and other ID values using int() to ensure proper type handling.
Applies similar changes across both incident and case interactive modules.