This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(slack): PlainOption requires string values #5980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where PlainOption in Slack blocks requires string values by explicitly converting the "value" keys in options and initial_option dictionaries to strings.
- Added processing for options and initial_option in static_select_block
- Added processing for options in multi_select_block
Comments suppressed due to low confidence (2)
src/dispatch/plugins/dispatch_slack/fields.py:268
- [nitpick] Consider renaming the loop variable 'x' to a more descriptive name such as 'option' for clarity.
for x in options:
src/dispatch/plugins/dispatch_slack/fields.py:306
- [nitpick] Consider renaming the loop variable 'x' to a more descriptive name such as 'option' for clarity.
for x in options:
wssheldon
approved these changes
May 16, 2025
Contributor
wssheldon
left a comment
wssheldon
left a comment
There was a problem hiding this comment.
we should update the type signature here to be correct and plan to address the callers incorrect usage, this masks the real issue imo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where PlainOption in Slack blocks requires string values by explicitly converting the "value" keys in options and initial_option dictionaries to strings.