This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(models): adding default None to create objects with optional attributes #5979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates various model classes to add default None values to optional attributes, ensuring that object creation behaves consistently across the codebase.
- Default values are now assigned for optional attributes in create models.
- Enhancements ensure consistency in API design for model object creation.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/dispatch/plugin/models.py | Added default None to optional 'enabled' and 'configuration'. |
| src/dispatch/notification/models.py | Set default None for 'filters' in NotificationCreate. |
| src/dispatch/entity_type/models.py | Added default None for 'id' in EntityTypeCreate. |
| src/dispatch/entity/models.py | Added default None for 'id' in EntityCreate and 'entity_type' in EntityReadMinimal. |
| src/dispatch/email_templates/models.py | Added default None for the optional 'project' attribute in EmailTemplatesCreate. |
| src/dispatch/data/alert/models.py | Added default None for 'id' in AlertCreate. |
| src/dispatch/auth/models.py | Added default None for 'projects' and 'organizations' in UserCreate. |
wssheldon
approved these changes
May 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates various model classes to add default None values to optional attributes, ensuring that object creation behaves consistent with previous Pydantic version.