This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(signal): set to None to allow missing parameters #5975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds default None values to several optional fields in signal and project models to allow missing parameters without validation errors.
- Added
= Nonedefaults for optional fields (case,external_id,signal,case_priority,case_type,conversation_target,oncall_service, andid) - Maintained backward compatibility for creating and reading signal instances and projects
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dispatch/signal/models.py | Set default None on newly optional attributes |
| src/dispatch/project/models.py | Added default None for id in ProjectRead |
Comments suppressed due to low confidence (1)
src/dispatch/signal/models.py:392
- Using a mutable default (
[]) can lead to shared state across instances. Consider using a PydanticField(default_factory=list)or defaulting toNoneand initializing in__init__.
entities: list[EntityRead] | None = []
mvilanova
reviewed
May 16, 2025
mvilanova
approved these changes
May 16, 2025
Contributor
mvilanova
left a comment
mvilanova
left a comment
There was a problem hiding this comment.
Let's take a harder look at the models in a future PR, as they're not in an ideal state.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds default None values to several optional fields in signal and project models to allow missing parameters without validation errors.