Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

fix(signal): log exception instead of warning for bad signal id #5692

Merged
whitdog47 merged 2 commits into from
Jan 16, 2025
Merged

fix(signal): log exception instead of warning for bad signal id #5692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
544edbd
fix(signal): log exception instead of warning for bad signal id
whitdog47 Jan 14, 2025
d00559e
Merge branch 'main' into bugfix/invalid-signal-id-exception
whitdog47 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dispatch/signal/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ def create_instance(
# remove non-serializable entities from the raw JSON:
signal_instance_in_raw = signal_instance_in.raw.copy()
if signal_instance_in.oncall_service:
signal_instance_in_raw.pop('oncall_service')
signal_instance_in_raw.pop("oncall_service")

# we round trip the raw data to json-ify date strings
signal_instance = SignalInstance(
Expand Down Expand Up @@ -603,7 +603,7 @@ def create_instance(

if signal_instance.id and not is_valid_uuid(signal_instance.id):
msg = f"Invalid signal id format. Expecting UUIDv4 format. Signal id: {signal_instance.id}. Signal name/variant: {signal_instance.raw['name'] if signal_instance and signal_instance.raw and signal_instance.raw.get('name') else signal_instance.raw['variant']}"
log.warn(msg)
log.exception(msg)
raise HTTPException(
status_code=status.HTTP_400_BAD_REQUEST,
detail=[{"msg": msg}],
Expand Down
Loading