This repository was archived by the owner on Sep 3, 2025. It is now read-only.
feat(signal instance): allow instance to specify oncall service and conversation target #5670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 21, 2024 11:45
…t/signal-instance-overrides
…t/signal-instance-overrides
aliciamatsumoto
requested review from
kevgliss,
mvilanova,
snkilmartin and
whitdog47
whitdog47
suggested changes
Jan 8, 2025
src/dispatch/database/revisions/tenant/versions/2024-12-17_dfc8e213a2c4.py
Outdated
Show resolved
Hide resolved
…8e213a2c4.py Co-authored-by: David Whittaker <84562015+whitdog47@users.noreply.github.com> Signed-off-by: Alicia Matsumoto <56315176+aliciamatsumoto@users.noreply.github.com>
whitdog47
approved these changes
Jan 9, 2025
snkilmartin
approved these changes
Jan 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes extend signal instances to be able to override their underlying signal definitions' configurations for conversation target and on-call service, revising a signal instance's attribute assignment logic to make assignments from the most specific entity's configurations to the least specific's: assign conversation target and on-call service based on the instance's configurations, falling back to the signal's, falling back to the case type's.
Changes
conversation_targetandoncall_serviceto theSignalInstancemodelsignal_instance_create_flowto use new attribute assignment logic (included updates to a few upstream functions to accommodate serialization nuances)Database changes
conversation_targetstring andoncall_service_idforeign key tosignal_instancetable via Alembic.No UI changes since signal instances cannot be created in the UI.