fix(tasks): adjust styles watcher implementation#141
Open
Hugoer wants to merge 1 commit intoNetcentric:mainfrom
Open
fix(tasks): adjust styles watcher implementation#141Hugoer wants to merge 1 commit intoNetcentric:mainfrom
Hugoer wants to merge 1 commit intoNetcentric:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with SCSS file watchers caused by Chokidar version > 3. In versions 4+, Chokidar no longer supports glob patterns directly.
Description
Downgraded chokidar from v5 to v4 to maintain NC FE Build compatibility (node version).
Use
fast-globto have the observer pre-filter the SCSS files and listen only to the specific list of files., instead of monitoring the entire${config.general.sourcesPath}folder. This ensures reliable detection of SCSS changes and improves watcher performance.Related Issue
Fixes #138
Types of changes
Checklist: