-
Notifications
You must be signed in to change notification settings - Fork 0
Update Angular, Drop dialog support, move from scss to css #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: Clients need to update to Angular 20 in order to use this version. As I wrote last october in #3, Dialog and Popup support were finally dropped. Only the "inline" mode is supported from now on. Additionally, probably irrelevant for clients, this library switched from scss to css which simplifies the build process.
# [20.0.0-rc.1](19.1.0...20.0.0-rc.1) (2025-06-18) ### Features * update Angular, Drop dialog support, move from scss to css ([f35dd7f](f35dd7f)) ### BREAKING CHANGES * Clients need to update to Angular 20 in order to use this version. As I wrote last october in #3, Dialog and Popup support were finally dropped. Only the "inline" mode is supported from now on. Additionally, probably irrelevant for clients, this library switched from scss to css which simplifies the build process.
|
This repository uses semantic-release to automate the process of releasing new versions. The following changelog entries would be generated for the next release. Please review them to ensure they correctly reflect the changes in this pull request. Changelog preview (the formatting is slightly different from the actual release): # 20.0.0 (https://github.com/netwin/date-time-picker/compare/19.1.0...20.0.0) (2025-07-20)
### Bug Fixes
* **deps:** update dependencies ([7762b54](https://github.com/netwin/date-time-picker/commit/7762b54f66338a2bc560850503cbe4f5db813aad))
### Features
* convert all components to standalone ([98092d2](https://github.com/netwin/date-time-picker/commit/98092d2795606639d55077306015c09a2838461b))
* update Angular, Drop dialog support, move from scss to css ([f35dd7f](https://github.com/netwin/date-time-picker/commit/f35dd7feab35d52ee2b6cf604a662b9823dd7cdf))
### BREAKING CHANGES
* Clients need to update to Angular 20 in order to use this version. As I wrote last october in #3, Dialog and Popup support were finally dropped. Only the "inline" mode is supported from now on. Additionally, probably irrelevant for clients, this library switched from scss to css which simplifies the build process. |
# [20.0.0-rc.2](20.0.0-rc.1...20.0.0-rc.2) (2025-07-20) ### Bug Fixes * **deps:** update dependencies ([7762b54](7762b54)) ### Features * convert all components to standalone ([98092d2](98092d2))
|
🎉 This PR is included in version 20.0.0-rc.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request modernizes the Angular picker library by upgrading to a newer Angular version, removing dialog support completely, and migrating from SCSS to CSS styling. The changes streamline the codebase by eliminating deprecated features, modernizing component architecture, removing unused utilities, and updating styling approaches.
- Removes all dialog-related functionality and dependencies
- Migrates SCSS files to CSS with modernized property syntax
- Updates component architecture to use newer Angular patterns (signals, dependency injection)
Reviewed Changes
Copilot reviewed 70 out of 85 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles.css | Updates stylesheet import path from SCSS to CSS |
| src/app/app.component.ts | Removes standalone component decorator and updates stylesheet reference |
| src/app/app.component.scss | Removes original SCSS file completely |
| src/app/app.component.css | Adds new CSS file with converted styles and modern syntax |
| projects/picker/src/styles/picker.css | Major refactor removing dialog/overlay styles, modernizing CSS syntax |
| projects/picker/src/public_api.ts | Reorganizes exports, removes dialog-related exports |
| projects/picker/src/test-helpers.ts | Simplifies test helper functions, removes unused parameters |
| Multiple component files | Updates to modern Angular patterns with signals and inject() |
Comments suppressed due to low confidence (1)
projects/picker/src/lib/date-time/options-provider.ts:32
- The multiYear token is defined but removed from the providers array, making it unused. Consider removing this unused token definition.
}
|
🎉 This PR is included in version 20.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
See commit message