Skip to content

Fix typos inside TestPopulateConfigurationDefaults_AllSet test #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dariakts wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typos inside TestPopulateConfigurationDefaults_AllSet test #1002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions storage_drivers/gcp/gcp_gcnv_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,6 +893,7 @@ func TestPopulateConfigurationDefaults_AllSet(t *testing.T) {
},
NFSMountOptions: "nfsvers=4.1",
VolumeCreateTimeout: "30",
NASType: "smb",
GCNVNASStorageDriverPool: drivers.GCNVNASStorageDriverPool{
GCNVNASStorageDriverConfigDefaults: drivers.GCNVNASStorageDriverConfigDefaults{
CommonStorageDriverConfigDefaults: drivers.CommonStorageDriverConfigDefaults{
Expand All @@ -905,7 +906,6 @@ func TestPopulateConfigurationDefaults_AllSet(t *testing.T) {
},
StorageClass: "software",
ServiceLevel: "premium",
NASType: "smb",
},
}

Expand All @@ -920,13 +920,13 @@ func TestPopulateConfigurationDefaults_AllSet(t *testing.T) {
assert.Equal(t, "premium", driver.Config.ServiceLevel, "service level mismatch")
assert.Equal(t, "software", driver.Config.StorageClass, "storage class mismatch")
assert.Equal(t, "nfsvers=4.1", driver.Config.NFSMountOptions, "NFS mount options mismatch")
assert.Equal(t, "30", driver.Config.VolumeCreateTimeout, "NFS mount options mismatch")
assert.Equal(t, "30", driver.Config.VolumeCreateTimeout, "volume create timeout mismatch")
assert.Equal(t, "true", driver.Config.SnapshotDir, "snapshot dir mismatch")
assert.Equal(t, "1456898458", driver.Config.SnapshotReserve, "snapshot reserve mismatch")
assert.Equal(t, "0700", driver.Config.UnixPermissions, "unix permissions mismatch")
assert.Equal(t, "123456789000", driver.Config.LimitVolumeSize, "limit volume size mismatch")
assert.Equal(t, "1.1.1.1/32", driver.Config.ExportRule, "export rule mismatch")
assert.Equal(t, sa.NFS, driver.Config.NASType, "NAS type mismatch")
assert.Equal(t, sa.SMB, driver.Config.NASType, "NAS type mismatch")
}

func TestPopulateConfigurationDefaults_InvalidSnapshotDir(t *testing.T) {
Expand Down