Skip to content

feat: adding iscsi service tool#70

Merged
cgrinds merged 25 commits intomainfrom
hl_iscsi
Apr 9, 2026
Merged

feat: adding iscsi service tool#70
cgrinds merged 25 commits intomainfrom
hl_iscsi

Conversation

@Hardikl
Copy link
Copy Markdown
Contributor

@Hardikl Hardikl commented Mar 24, 2026

No description provided.

Comment thread docs/examples.md Outdated
Comment thread docs/examples.md
Comment thread tool/tool.go Outdated
Comment thread tool/tool.go
Comment thread rest/iscsiService.go Outdated
Comment thread rest/iscsiService.go Outdated
Comment thread tool/tool.go
Comment thread rest/iscsiService.go
Comment thread integration/test/tools_test.go Outdated
Copilot AI review requested due to automatic review settings March 26, 2026 12:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new MCP tool set for managing ONTAP iSCSI services, wiring it through the server, REST client, and data models, along with integration coverage and docs examples.

Changes:

  • Introduces create_iscsi_service, update_iscsi_service, and delete_iscsi_service tools and registers them with the MCP server.
  • Adds REST client support and ONTAP model types for iSCSI service operations.
  • Adds integration test coverage and user prompt examples for iSCSI service management.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tool/tool.go Adds the IscsiService tool parameter schema.
server/server.go Registers iSCSI service tools with the MCP server.
server/iscsiService.go Implements server tool handlers and request builders for iSCSI service CRUD.
rest/iscsiService.go Implements REST calls to ONTAP iSCSI service endpoints.
ontap/ontap.go Adds ONTAP model structs (IscsiService, Target) for request/response payloads.
integration/test/iscsi_test.go Adds integration test prompts/verification for iSCSI service operations.
docs/examples.md Adds example prompts for iSCSI service management.
descriptions/descriptions.go Adds tool descriptions for iSCSI service operations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ontap/ontap.go Outdated
Comment thread ontap/ontap.go Outdated
Comment thread server/iscsiService.go Outdated
Comment thread docs/examples.md Outdated
Comment thread tool/tool.go
Comment thread rest/iscsiService.go Outdated
Comment thread server/iscsiService.go Outdated
Comment thread rest/iscsiService.go Outdated
@rahulguptajss rahulguptajss linked an issue Mar 27, 2026 that may be closed by this pull request
Copilot AI review requested due to automatic review settings March 27, 2026 10:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tool/tool.go
Comment thread ontap/ontap.go
Comment thread server/iscsiService.go
Comment thread rest/iscsiService.go Outdated
Comment thread integration/test/iscsi_test.go
Copilot AI review requested due to automatic review settings March 30, 2026 10:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread server/iscsiService.go
Comment thread tool/tool.go Outdated
Comment thread integration/test/iscsi_test.go Outdated
Comment thread rest/iscsiService.go
Comment thread rest/iscsiService.go Outdated
Copilot AI review requested due to automatic review settings March 30, 2026 15:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread server/iscsiService.go Outdated
Comment thread server/iscsiService.go
Copilot AI review requested due to automatic review settings March 31, 2026 08:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tool/tool.go Outdated
Comment thread docs/examples.md Outdated
Comment thread docs/examples.md Outdated
Comment thread integration/test/iscsi_test.go Outdated
Comment thread integration/test/iscsi_test.go
Comment thread integration/test/iscsi_test.go
Comment thread integration/test/iscsi_test.go
Comment thread server/iscsiService.go
@cla-bot cla-bot bot added the cla-signed label Apr 8, 2026
Copilot AI review requested due to automatic review settings April 8, 2026 09:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/examples.md Outdated
Comment thread server/iscsiService.go
Copilot AI review requested due to automatic review settings April 8, 2026 13:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread server/iscsiService.go
Comment thread server/iscsiService.go
Comment thread server/iscsiService.go Outdated
Comment thread server/iscsiService.go
Comment thread rest/iscsiService.go
Comment thread rest/iscsiService.go
@cgrinds cgrinds merged commit f3c7f07 into main Apr 9, 2026
19 checks passed
@cgrinds cgrinds deleted the hl_iscsi branch April 9, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add iSCSI service/interface management tools

4 participants