Try to optimize len() implementation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atomic len field in type GenericBPlusTree. And do some chores like remove undeclared mod bench
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that in the current
len()impl of typeGenericBPlusTreeinlib.rstraverse and iterate through the structure, I wonder whether it is necessary: I don't fully understand the impl, but I think the insertion and removal methods ofGenericBPlusTreeis transactional, so I personally thought that if we introduce and maintain a len field, that keeps track of the active element, then the iteration can be avoided inlen(), i.e. the time complexity is O(1).I tried to implement it with AtomicUsize and the corresponding memory order. But I didn't do full integrated tests; rather, I only did unit tests.
Since the preliminary unit test in a multithreading environment is passed, I thought maybe that optimization is feasible? Or I didn't understand the design?