Conversation
Not sure I like it, but it compiles. Also switches atomic_polyfill for the supported portable_atomic.
thejpster
force-pushed
the
fix-rust-183
branch
from
28a6141 to
e104619
Compare
Member
Author
|
PCM audio works, but video is flickery and the fifth character column is missing. |
Locking the mutex costs too much - it mades the video lose sync. Not helped by the fact the acquire function is stored in flash and is not inlined. Store the mode info as two atomic values instead.
Member
Author
|
Now the video looks OK. |
thejpster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure I like it, but it compiles.
Also switches atomic_polyfill for the supported portable_atomic.
TODO: