Add possibility to enforce row or col span #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, this is helpful to unify the appearance of tables using a row span for some rows and no row span for others. Without an explicitly defined row span of 1, CSS will not apply the corresponding style. Signed-off-by: Benny Fuhry <benny.fuhry@intel.com>
RobertoPrevato
force-pushed
the
bfuhry/enforce_span
branch
from
80c3591 to
6ffa888
Compare
Member
|
Hi @BFuhry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, this is helpful to unify the appearance of tables using a row span for some rows and no row span for others. Without an explicitly defined row span of 1, CSS will not apply the corresponding style.
Only if
@spanX:1or@span1:Yis used, there will be a difference, because the author is very explicit in this case.In all other cases, in particular for
@span,@spanX:0or@span0:Y, the proposed changes lead to exactly the same result.A corresponding documentation change is needed.
I can provide it if this PR is acceptable overall.