added Percent (not as Measurement)#21
Merged
NeedleInAJayStack merged 2 commits intoNeedleInAJayStack:mainfrom Sep 19, 2025
Merged
added Percent (not as Measurement)#21NeedleInAJayStack merged 2 commits intoNeedleInAJayStack:mainfrom
NeedleInAJayStack merged 2 commits intoNeedleInAJayStack:mainfrom
Conversation
Owner
NeedleInAJayStack
left a comment
NeedleInAJayStack
left a comment
There was a problem hiding this comment.
Hey sorry about the delay in review. This is awesome! Thanks!
I see you've added % into the unit system. I think that might be all we need for the parser to work correctly, but it may not use the correct +/- arithmetic. Could we add a test to validate its behavior?
Thanks again!
Author
|
You were right (it appears :-) ), adding in the Percent as you suggested makes the parser happy and I updated the Expression solver correctly -- at least my tests pass :-) |
NeedleInAJayStack
approved these changes
Sep 19, 2025
Owner
NeedleInAJayStack
left a comment
NeedleInAJayStack
left a comment
There was a problem hiding this comment.
Thanks again @wildthink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you like this approach, I'll fully document it for a formal pull request.
I have some questions/ideas about it could be fully integrated into the Parser, etc.