Open
Conversation
…enuBar options.
# Conflicts: # resources/electron/electron-plugin/src/server/api/menuBar.ts
simonhamp
approved these changes
Mar 16, 2026
SRWieZ
approved these changes
Mar 20, 2026
Member
SRWieZ
left a comment
SRWieZ
left a comment
There was a problem hiding this comment.
Someone told me at Larcon that it needed that too. I think it's a good idea. Thanks @WINBIGFOX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MenuBarexposes the standard dimension API viaHasDimensions, but its Electron bridge currently ignoresminWidth,minHeight,maxWidth, andmaxHeightwhen creating the underlyingBrowserWindow.This becomes a problem for tray/menubar apps: the menubar popup can gradually shrink after repeated reopenings, especially in multi-display setups with different resolutions/scaling, and the app has no way to enforce a minimum usable size even though the PHP API suggests that it can.
This change forwards the min/max dimension values through the
electron-pluginmenubar create flow so applications can reliably constrain the popup window size.