-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat: integrate Laravel Nightwatch support #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added `laravel/nightwatch` dependency to composer.json and implemented environment variable and server startup logic for Nightwatch integration. Updated API routes to include Nightwatch middleware for enhanced functionality.
|
Hey @WINBIGFOX Thanks for your contribution! You are on a roll! I like it! How do you feel about not requiring the package by default. We could even check if the Nightwatch service provider exists to see if it's installed before starting the worker. This way we make it opt-in. It won't matter much (nightwatch is 1.4mb unzipped) but I like the idea. @simonhamp what's your take on this? |
|
Another thing just struck me. How does Nightwatch handle it when multiple clients post to the same project? Not sure if Nightwatch will handle that gracefully. Have you tried using it on multiple devices? |
…chNever Removed `laravel/nightwatch` dependency and introduced `OptionalNightwatchNever` middleware to conditionally handle Nightwatch functionality. Updated API routes and server logic to reflect middleware replacement and improve compatibility.
|
Hi @gwleuverink, thanks a lot for your feedback! Regarding your note about multiple clients: in my experience, Laravel Nightwatch doesn’t have any issues when multiple clients send data to the same Nightwatch project. I assume that’s what you meant, right? |
|
@simonhamp what are your thoughts on this? |
|
I'd love to see how this shakes out - Nightwatch could be an ideal partner for NativePHP apps Let's do it! |
Added
laravel/nightwatchdependency to composer.json and implemented environment variable and server startup logic for Nightwatch integration. Updated API routes to include Nightwatch middleware for enhanced functionality.