Skip to content

Set FCID to whatever is scanned during sequencing setup#16

Merged
ssjunnebo merged 8 commits intoNationalGenomicsInfrastructure:masterfrom
ssjunnebo:fcid_rename
Mar 20, 2026
Merged

Set FCID to whatever is scanned during sequencing setup#16
ssjunnebo merged 8 commits intoNationalGenomicsInfrastructure:masterfrom
ssjunnebo:fcid_rename

Conversation

@ssjunnebo
Copy link
Contributor

  • Set FCID to whatever is scanned during sequencing setup (i.e. remove the side letter for MiSeq100, NovaSeqXPlus and Aviti)
  • Specify the path to the metadata archive for each sequencer in the config file

@ssjunnebo ssjunnebo added the no validation validation not needed label Mar 19, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.00%. Comparing base (13e553a) to head (72c6c60).
⚠️ Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
dataflow_transfer/run_classes/element_runs.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   87.86%   88.00%   +0.13%     
==========================================
  Files          10       10              
  Lines         519      575      +56     
  Branches       30       33       +3     
==========================================
+ Hits          456      506      +50     
- Misses         60       65       +5     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ssjunnebo ssjunnebo requested review from aanil and alneberg March 19, 2026 07:34
Copy link
Member

@aanil aanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ssjunnebo ssjunnebo merged commit d632350 into NationalGenomicsInfrastructure:master Mar 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no validation validation not needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants