Itc basis updates#2187
Conversation
avoid < 0 error msg
…itc_basis_updates
allocation options, update callbacks
…itc_basis_updates
…itc_basis_updates
…attery, and custom generation battery
|
New UI looks good, thanks Paul! The latest updates extend this functionality (and detailed depreciation) to commercial. Please test when you get a chance. |
sjanzou
left a comment
sjanzou
left a comment
There was a problem hiding this comment.
Version upgrade works great and configurations run.
Issues
- Send to Excel with Equations for PV-Batt-Com has error message
- Send to Excel with Equations for PVWatts-SO has error message
- (Probably a separate issue) IPH-MS-Liner-Fresnel-LCOH requires going through all forms before running - seems to be a left over issue from 2025.4.16.
Project files used to upgrade and test
| "batt_replacement_option": 1, | ||
| "batt_replacement_schedule_percent": [0.000000], | ||
| "batt_surface_area": 1227.67, | ||
| "batt_surface_area": 18000, |
There was a problem hiding this comment.
Kind of large surface area changes for the battery - is that expected?
There was a problem hiding this comment.
This is a downstream change from https://github.com/NatLabRockies/SAM/pull/2185/changes, sorry for not updating the computed defaults in that PR!
| sl_39 = oldvalue('depr_alloc_sl_39_percent'); | ||
| custom = oldvalue('depr_alloc_custom_percent'); | ||
|
|
||
| value('ui_depr_alloc_macrs_5_percent', macrs_5, "Copying existing allocation to new UI variable."); |
There was a problem hiding this comment.
My previous question answered and working for old files for me.
There was a problem hiding this comment.
Send to Excel with Equations for PV-Batt-Com has error message
In my tests, I don't get an error, but the metrics in Excel do not match those in the SAM metrics table.
…how empty variable names. Also fix some variables set to "Default" UI widget.
sjanzou
left a comment
sjanzou
left a comment
There was a problem hiding this comment.
Upgrade working with the intermittent issue with the IPH Lin Fres - Com configuration per the SAM meeting 5/27/2026. All other tests are working for me... Maybe another round of testing once all the defaults are updated? Separate pull request?
Defaults changes that we discussed in the meeting were pushed in 36b3b2a Further defaults updates such as updating default PPA prices in light of these changes are in the queue for next week. If I recall correctly, @cpaulgilman is planning to fix the issues he found with the send to excel spreadsheets, and then this should be ready to merge. |
Yes, that's fixed now, so this is ready to merge. We can deal with other issues Steve found separately. |
4 participants
Pull Request Template
Description
Add new functionality to specify ITC and depreciation bases by technology installed cost. Update defaults to match post OBBBA phase outs (for projects that start construction after July 4th 2026 and don't enter operation before Dec 31 2026). Add bonus depreciation.
Help updates will be completed in parallel with feature reviews.
Expect many negative NPVs. PPA prices will be updated in a future PR.
References:
-General: https://fbtgibbons.com/one-big-beautiful-bill-act-cuts-the-power-phase%e2%80%91outs-foreign%e2%80%91entity-restrictions-and-domestic-content-in-clean%e2%80%91energy-credits/
Corresponding branches and PRs:
itc_basis_updates on ssc (NatLabRockies/ssc#1395)
Develop on other branches.
Unit Test Impact:
Test results changed due to tax credit defaults and default depreciation bases changes.
Checklist