Add NFP for SpaceLoadDefinitions#11614
Open
kbenne wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Group discussion at the EnergyPlus technicalities meeting was favorable, but one discussion point was (and is) the split between what goes in the instance object versus what goes in the definition object. Please comment with your thoughts in case we need to make any revisions to the design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Adds the NFP design document for splitting internal gains objects into instance and definition objects, aligning EnergyPlus with OpenStudio’s reusable space load definition pattern.