Fix VRF Thermostat Control Type Issues#11611
Open
mitchute wants to merge 3 commits into
Open
Conversation
rraustad
reviewed
Jun 1, 2026
| state.dataHVACVarRefFlow->CoolingLoad(VRFCond) = true; | ||
| } else if (state.dataHVACVarRefFlow->VRF(VRFCond).prioritySched->getCurrentVal() == 1) { | ||
| state.dataHVACVarRefFlow->HeatingLoad(VRFCond) = true; | ||
| state.dataHVACVarRefFlow->CoolingLoad(VRFCond) = false; |
Collaborator
There was a problem hiding this comment.
just wondering why? If scheduled didn't work before then it doesn't matter but why bother changing this?
Collaborator
Author
There was a problem hiding this comment.
This is to align the behavior with the IDD.
A26, \field Thermostat Priority Schedule Name
\type object-list
\object-list ScheduleNames
\note this field is required if Master Thermostat Priority Control Type is Scheduled.
\note Schedule values of 0 denote cooling, 1 for heating, and all other values disable the system.
mitchute
commented
Jun 1, 2026
| state.dataHVACVarRefFlow->CoolingLoad(VRFCond) = true; | ||
| } else if (state.dataHVACVarRefFlow->VRF(VRFCond).prioritySched->getCurrentVal() == 1) { | ||
| state.dataHVACVarRefFlow->HeatingLoad(VRFCond) = true; | ||
| state.dataHVACVarRefFlow->CoolingLoad(VRFCond) = false; |
Collaborator
Author
There was a problem hiding this comment.
This is to align the behavior with the IDD.
A26, \field Thermostat Priority Schedule Name
\type object-list
\object-list ScheduleNames
\note this field is required if Master Thermostat Priority Control Type is Scheduled.
\note Schedule values of 0 denote cooling, 1 for heating, and all other values disable the system.
| \paragraph{Field: Thermostat Priority Schedule Name}\label{field-thermostat-priority-schedule-name-000} | ||
|
|
||
| This alpha field identifies the schedule used when the previous field is set to Scheduled. Schedule values of 0 denote heating mode while values of 1 denote cooling mode. Any other values will force the system off. | ||
| This alpha field identifies the schedule used when the previous field is set to Scheduled. Schedule values of 0 denote cooling mode while values of 1 denote heating mode. Any other values will force the system off. |
Collaborator
Author
There was a problem hiding this comment.
IDD vs. the code & docs had these reversed. I deferred to the IDD, but we can change that if the reverse would be better.
| } | ||
|
|
||
| if (thisVrfSys.ThermostatPriority == ThermostatCtrlType::ScheduledPriority) { | ||
| if (thisVrfSys.ThermostatPriority == ThermostatCtrlType::Scheduled) { |
Collaborator
Author
There was a problem hiding this comment.
Renamed to be consistent with the IDD key choice.
Comment on lines
-10284
to
-10286
| case ThermostatCtrlType::FirstOnPriority: { | ||
| // na | ||
| } break; |
Collaborator
Author
There was a problem hiding this comment.
Unused, so I got rid of it.
Comment on lines
+95
to
+99
| "LOADPRIORITY", | ||
| "MASTERTHERMOSTATPRIORITY", | ||
| "SCHEDULED", | ||
| "THERMOSTATOFFSETPRIORITY", | ||
| "ZONEPRIORITY", |
Collaborator
Author
There was a problem hiding this comment.
Removed the unused place holder, and sorted the list.
mitchute
commented
Jun 1, 2026
| }; | ||
|
|
||
| static constexpr std::array<std::string_view, static_cast<int>(ThermostatCtrlType::Num)> ThermostatCtrlTypeUC = { | ||
| "LOADPRIORITY", "ZONEPRIORITY", "THERMOSTATOFFSETPRIORITY", "SCHEDULEDPRIORITY", "MASTERTHERMOSTATPRIORITY", |
Collaborator
Author
There was a problem hiding this comment.
This is the real fix - changing SCHEDULEDPRIORITY to SCHEDULED since that is the key in the IDD that this is looking for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
AirConditioner:VariableRefrigerantFlownot working withScheduledmaster thermostat #11610Description of the purpose of this PR
Pull Request Author
Reviewer