Convert the ReadVars Fortran program into Python#11598
Draft
jasondegraw wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
There have periodically been requests to translate the Fortran utilities to Python or C++, there's an issue here:
#6566
We haven't managed to get many of those converted for one reason or another. A few days ago, I needed to convert some ESOs into CSVs and I didn't have an installed copy of EnergyPlus or a Fortran compiler, but I did have the EnergyPlus source and the Codex agent pointed at it, so I asked Codex to write me a Python version of ReadVars so I could do the conversion. It's come up a few times before and I thought it'd be useful to have a Python version to stash someplace and use when I needed it.
Well, I guess the prompt I wrote was too open-ended: it nuked the Fortran and replaced it with the Python version that it wrote. @mbadams5 points out that Codex just did what I should have asked for. The
-rswitch now should invoke the Python version instead of "real" executable.I'm going to put it in draft mode for now to see how it fairs in CI, and I want to do some testing of the performance beyond the basic Windows use that I have done already.
Pull Request Author
Reviewer