Safe preview and confirmation flow#271
Open
mekeke111 wants to merge 3 commits into
Open
Conversation
- Add centralized confirmation utility module (src/utils/confirmation.rs) - Enhance deploy.rs with detailed confirmation summary and mainnet warnings - Enhance tx.rs (send/batch) with detailed confirmation summaries - Add confirmation to invoke.rs before submission (critical gap fixed) - Enhance wallet merge with detailed confirmation summary - Enhance upgrade execute/rollback with detailed confirmation summaries - Implement consistent mainnet warnings across all risky commands - Add type-to-confirm for high-risk operations (mainnet, account merge) - Support dry-run/preview modes where applicable
|
@mekeke111 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces safer execution workflows for high-risk operations by adding preview, validation, and confirmation steps before actions are performed.
The goal is to reduce accidental deployments, unintended network changes, and misuse of blockchain resources by ensuring users can review actions before execution.
Changes Made
Confirmation Flows
Preview & Validation
Mainnet Safety Warnings
User Experience Improvements
Acceptance Criteria
Testing
Closes #211