command to add school approver to all projects associated with the school #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the school approver management command: - Improve logic for checking if approver is already in project - Fix logger method from warn to warning - Add proper approver profile access Add comprehensive test suite for add_school_approver_to_all_projects command: - Test successful approver addition to projects - Test dry run functionality - Test skipping projects where approver already exists - Test error handling for nonexistent users and schools - Test validation that user is approver for specified school - Test handling of users without approver profiles Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
s-sajid-ali
changed the title
Updated root logger configuration to include both console and file handlers, allowing management commands and other loggers to output to both STDOUT and log files by default. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
s-sajid-ali
force-pushed
the
add_school_approver_to_projects
branch
from
b51431b to
c90ca99
Compare
modified: coldfront/core/school/management/commands/add_school_approver_to_all_projects.py
s-sajid-ali
force-pushed
the
add_school_approver_to_projects
branch
from
fe0a09b to
4871d3b
Compare
Member
Author
|
The tests cover more scenarios than we expect to see, but it's no harm to have them in the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.