NOREF: Fix PDF scrolling and programmatic navigation bugs#197
Merged
jackiequach merged 2 commits intomainfrom Mar 3, 2026
Merged
NOREF: Fix PDF scrolling and programmatic navigation bugs#197jackiequach merged 2 commits intomainfrom
jackiequach merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alea12
reviewed
Mar 3, 2026
src/PdfReader/index.tsx
Outdated
Comment on lines
+243
to
+248
| const scrollState = React.useRef({ | ||
| ratios: new Map<number, number>(), | ||
| lastVisiblePage: state.pageNumber, | ||
| isInViewUpdate: false, | ||
| lastProgrammaticNavAt: 0, | ||
| }); |
Member
There was a problem hiding this comment.
Could we move scrollState declaration above the useEffect that references it since useRef calls aren't hoisted? Or was this ordering intentional?
alea12
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onInViewto ignore off-screen pages. Adds a programmatic navigation delay that preventsgoForward,goBackward, andgoToPagefrom triggeringonInView, which sometimes caused the reader to jump pages if multiple pages were visible at once.