Fix deep linking config based on stack changes#1165
Merged
stevekuznetsov merged 1 commit intoNWACus:kevinherdez/mapProjectfrom Apr 20, 2026
Merged
Conversation
kevinherdez
force-pushed
the
kevinherdez/fixDeepLinkingMapProj
branch
from
ee1016f to
5413567
Compare
Collaborator
|
this flow makes sense and looks very clean! my only thought here is that this modal doesnt have a "share" in there. not a big deal since someone shared it with me and I can go back to the text I got it from and copy and paste the link to share with someone else but it woudn't be an uncommon flow for someone to send me a link to an observation and then me wanting to send it someone else. |
Collaborator
Author
|
Makes sense. We have this issue #1160 tracking a bigger discussion around how to make the details page better in terms of letting a user know where the observation is coming from. That could help this flow because it might feel a little crowded to have both the logo and the share button in the header |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
linking configfor the new stack and introducesObservationDetailViewModal.The reason for the addition is that we want to show the
ObservationDetailViewfrom a modal instead of pushing it onto the stack. I decided to break this out into a separate view because the header that we show depending on if we're showing the modal or showing the stack is different, and I didn't want to overloadNavigationStackHeaderfor this one use case.