Skip to content

core(basic sender): fix trailing return type#2081

Open
romintomasetti wants to merge 1 commit into
NVIDIA:mainfrom
romintomasetti:env-trailing-return
Open

core(basic sender): fix trailing return type#2081
romintomasetti wants to merge 1 commit into
NVIDIA:mainfrom
romintomasetti:env-trailing-return

Conversation

@romintomasetti
Copy link
Copy Markdown
Contributor

@romintomasetti romintomasetti commented May 18, 2026

This PR changes a decltype(auto) to a proper trailing return type, avoiding instantiation of stuff that ends up trying to instantiate stuff for incomplete types.

I've added a new test that does not compile if the trailing return type is turned back to decltype(auto).

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 18, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@romintomasetti
Copy link
Copy Markdown
Contributor Author

@maartenarnst

Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
@romintomasetti
Copy link
Copy Markdown
Contributor Author

@ericniebler Not sure about the quality of the trailing return type but we need it in our code base to avoid incomplete type issues. Would you have a minute to take a look ? Thks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant