Remove local classes in function templates#2079
Open
ahmedhussein89 wants to merge 10 commits into
Open
Conversation
…ce for improved signature handling
…ng and add __emplace_from_fn for enhanced function emplacement
…tion structures for improved clarity and organization
…parallel scheduler
Collaborator
|
#542 is about compile-time performance. have you done benchmarking to determine whether these changes improve compile times? EDIT: i should also say that the changes look like improvements, thanks. |
Collaborator
|
/ok to test ecf7b1a |
Author
My setup
-- System : Linux-6.6.87.2-microsoft-standard-WSL2
-- System name : Linux
-- System ver : 6.6.87.2-microsoft-standard-WSL2
--
-- Library ver : 0.11.0
-- Build date : 2026-05-18
-- Build year : 2026
--
-- CPM: Adding package Catch2@3.14.0 (3.14.0)
CMake Warning (dev) at /usr/share/cmake-4.2/Modules/FetchContent.cmake:1963 (message):
Calling FetchContent_Populate(Catch2) is deprecated, call
FetchContent_MakeAvailable(Catch2) instead. Policy CMP0169 can be set to
OLD to allow FetchContent_Populate(Catch2) to be called directly for now,
but the ability to call it with declared details will be removed completely
in a future version.
Call Stack (most recent call first):
build/cmake/CPM_0.38.5.cmake:1004 (FetchContent_Populate)
build/cmake/CPM_0.38.5.cmake:798 (cpm_fetch_package)
build/cmake/CPM_0.38.5.cmake:292 (CPMAddPackage)
build/_deps/rapids-cmake-src/rapids-cmake/cpm/find.cmake:189 (CPMFindPackage)
CMakeLists.txt:127 (rapids_cpm_find)
This warning is for project developers. Use -Wno-dev to suppress it.
-- CPM: Adding package icm@1.5.0 (v1.5.0)
CMake Warning (dev) at /usr/share/cmake-4.2/Modules/FetchContent.cmake:1963 (message):
Calling FetchContent_Populate(icm) is deprecated, call
FetchContent_MakeAvailable(icm) instead. Policy CMP0169 can be set to OLD
to allow FetchContent_Populate(icm) to be called directly for now, but the
ability to call it with declared details will be removed completely in a
future version.
Call Stack (most recent call first):
build/cmake/CPM_0.38.5.cmake:1004 (FetchContent_Populate)
build/cmake/CPM_0.38.5.cmake:798 (cpm_fetch_package)
build/_deps/rapids-cmake-src/rapids-cmake/cpm/find.cmake:187 (CPMAddPackage)
CMakeLists.txt:140 (rapids_cpm_find)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Enabling TBB support in stdexec because <tbb/tbb.h> is available and libstdc++ is used.
-- Creating symlink from ".../stdexec/build/compile_commands.json" to .../stdexec/compile_commands.json"...
-- Configuring done (0.5s)
-- Generating done (0.1s)
-- Build files have been written to: .../stdexec/buildPlease tell me if you need more info |
ericniebler
reviewed
May 18, 2026
Co-authored-by: Eric Niebler <eniebler@boost.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR solve #542