Skip to content

restrict NRI injection of CDI devices to pods in the toolkit's namespace #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elezar merged 1 commit into from
Jan 23, 2026
Merged

restrict NRI injection of CDI devices to pods in the toolkit's namespace #1601

elezar merged 1 commit into from
Jan 23, 2026
+27 −8

Conversation

@tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented Jan 22, 2026

No description provided.

@coveralls
Copy link

coveralls commented Jan 22, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 21287096193

Details

  • 1 of 15 (6.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 36.784%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/nvidia-ctk-installer/main.go 1 4 25.0%
cmd/nvidia-ctk-installer/container/runtime/nri/plugin.go 0 11 0.0%
Totals Coverage Status
Change from base Build 21281211577: -0.01%
Covered Lines: 5259
Relevant Lines: 14297
💛 - Coveralls

@tariq1890 tariq1890 force-pushed the nri-restrict-namespaces branch 2 times, most recently from 69f3cce to eb966d4 Compare January 22, 2026 06:07
elezar
elezar reviewed Jan 22, 2026
View reviewed changes
elezar
elezar reviewed Jan 22, 2026
View reviewed changes
@tariq1890 tariq1890 force-pushed the nri-restrict-namespaces branch from eb966d4 to 5b102e8 Compare January 22, 2026 20:56
@tariq1890 tariq1890 requested a review from cdesiniotis January 23, 2026 00:36
elezar
elezar reviewed Jan 23, 2026
View reviewed changes
@elezar elezar force-pushed the nri-restrict-namespaces branch from 5b102e8 to 8a9cb53 Compare January 23, 2026 09:33
@tariq1890 @elezar
restrict NRI injection of CDI devices to pods in the toolkit's namespace
eb4a252 
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@elezar elezar force-pushed the nri-restrict-namespaces branch from 8a9cb53 to eb4a252 Compare January 23, 2026 13:03
@elezar elezar added this to the v1.19.0 milestone Jan 23, 2026
@elezar elezar merged commit f7c494f into main Jan 23, 2026
16 checks passed
@elezar elezar deleted the nri-restrict-namespaces branch January 23, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elezar elezar elezar approved these changes

@cdesiniotis cdesiniotis Awaiting requested review from cdesiniotis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.19.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tariq1890 @coveralls @elezar