Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented Jan 21, 2026

This change ensures that we use the same golang version to build the NVIDIA Container Toolkit packages and the packages in libnvidia-container.

This requires NVIDIA/libnvidia-container#334 and also bumps libnvidia-container to NVIDIA/libnvidia-container@a83ddc0

@elezar elezar added this to the v1.19.0 milestone Jan 21, 2026
@elezar
Copy link
Member Author

elezar commented Jan 21, 2026

We may want to consider backporting this and NVIDIA/libnvidia-container#334

@coveralls
Copy link

coveralls commented Jan 21, 2026

Pull Request Test Coverage Report for Build 21243673534

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.84%

Totals Coverage Status
Change from base Build 21183749927: 0.0%
Covered Lines: 5257
Relevant Lines: 14270

💛 - Coveralls

@elezar elezar marked this pull request as draft January 22, 2026 09:01
Bumps [third_party/libnvidia-container](https://github.com/NVIDIA/libnvidia-container) from `584976a` to `a83ddc0`.
- [Release notes](https://github.com/NVIDIA/libnvidia-container/releases)
- [Commits](NVIDIA/libnvidia-container@584976a...a83ddc0)

---
updated-dependencies:
- dependency-name: third_party/libnvidia-container
  dependency-version: a83ddc087e255fa88612f7d6afa43acdd71ddd96
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the forward-golang-version-to-libnvidia-container branch from c6841f5 to 748ccdf Compare January 22, 2026 09:36
@elezar elezar marked this pull request as ready for review January 22, 2026 09:38
This change ensures that we use the same golang version to build the
NVIDIA Container Toolkit packages and the packages in libnvidia-container.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the forward-golang-version-to-libnvidia-container branch from 748ccdf to 008b4a9 Compare January 22, 2026 09:45
@elezar elezar merged commit e2b8891 into NVIDIA:main Jan 23, 2026
16 checks passed
@elezar elezar deleted the forward-golang-version-to-libnvidia-container branch January 23, 2026 13:17
@elezar
Copy link
Member Author

elezar commented Jan 23, 2026

/cherry-pick release-1.18

@github-actions
Copy link

🤖 Backport PR created for release-1.18: #1607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants