fix(provisioner): expose CRI-O bundled runtimes on PATH for AL2023#824
Merged
ArangoGutierrez merged 1 commit intoMay 26, 2026
Merged
Conversation
The opensuse CRI-O RPM on Amazon Linux 2023 bundles its OCI runtimes (runc, crun, conmon, pinns) under /usr/libexec/crio/ rather than on PATH. nvidia-container-toolkit 1.19.1 changed 'nvidia-ctk runtime configure --runtime=crio' to require pre-existing runc/crun entries in crio's config to preserve them when writing the /etc/crio/crio.conf.d/99-nvidia.toml drop-in. Without those entries, nvidia-ctk logs: level=warning msg="Could not infer options from runtimes [runc crun]" and writes a drop-in that omits the runtime tables. The subsequent 'systemctl restart crio' then fails because crio has no usable runtimes, breaking every AL2023 E2E job (rpm-al2023). Symlinking the bundled runtimes into /usr/bin/ in the AL2023 branch of the CRI-O install template lets nvidia-ctk discover them and preserve them in the merged config. RHEL and Debian remain unaffected because their CRI-O packages install runtimes on PATH to begin with. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Coverage Report for CI Build 26411556733Coverage remained the same at 48.745%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Collaborator
Author
|
Friendly bump @mchmarny — this PR fixes the AL2023 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
rpm-al2023E2E job has been failing on every merge tomainsince 2026-05-25 12:15Z (4 consecutive CI runs, all on different commits, the first of which is the docs-only #819 — proof this is not a code regression introduced by holodeck).CI log (run #26402728532, job
e2e-test / E2E Test (rpm-al2023)):Root cause
nvidia-container-toolkit 1.19.1changednvidia-ctk runtime configure --runtime=crioto require pre-existingrunc/crunentries in crio's config in order to preserve them when writing/etc/crio/crio.conf.d/99-nvidia.toml. The opensuse CRI-O RPM on AL2023 bundles its OCI runtimes under/usr/libexec/crio/rather than installing them onPATH, so nvidia-ctk cannot discover them and writes a drop-in that omits the runtime tables. The subsequentsystemctl restart criothen fails because crio has no usable runtimes.RHEL/Fedora and Debian are unaffected because their CRI-O packages install runtimes on
PATHto begin with.Fix
Symlink the bundled binaries (
runc,crun,conmon,pinns) from/usr/libexec/crio/into/usr/bin/in the AL2023 branch ofpkg/provisioner/templates/crio.go, aftercri-ois installed but before nvidia-container-toolkit runs. The symlinks are idempotent ([[ -x src && ! -e dst ]]).Testing
TestCriO_Execute_PackageTemplate_OSFamilyBranchingextended to assert the AL2023 branch installs symlinks covering at leastruncandcrun.go test ./pkg/... ./internal/...: green locally.rpm-al2023(and the rest of the matrix) in CI.Scope
Targeted, AL2023-only, 25-line diff. No behavioral change for any other OS family. Required for cutting v0.3.4.