Skip to content

[state-toolkit] add support for mounting runtime NRI sockets #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tariq1890 merged 1 commit into from
Jan 16, 2026
Merged

[state-toolkit] add support for mounting runtime NRI sockets #1950

tariq1890 merged 1 commit into from
Jan 16, 2026
+179 −6

Conversation

@tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented Dec 1, 2025 •
edited
Loading

Add support for enabling NRI Plugin and leveraging the same when injecting GPU management CDI devices to all of the operands.

Summary of changes

  • Adds a new field in the ClusterPolicy CRD .spec.cdi.nriPluginEnabled | (true|false) default: false
  • NRI Plugin will only be enabled if CDI is enabled.
  • If NRI Plugin is enabled, then the operands are rendered with the NRI annotation instead of the nvidia runtime class in their pod spec after the Transform methods are run.
  • This PR assumes that when NRI Plugin is enabled, the toolkit will no longer need to configure the runtime config TOML and restart the runtime process. Changes to enable both workflows will be addressed in another PR if this is required

@tariq1890 tariq1890 force-pushed the nri-socker-vol-mount branch from 82eb89f to 89cea24 Compare December 1, 2025 23:12
@coveralls
Copy link

coveralls commented Dec 1, 2025 •
edited
Loading

Coverage Status

coverage: 25.215% (+0.1%) from 25.072%
when pulling d5d7f0a on nri-socker-vol-mount
into 54ff621 on main.

@tariq1890 tariq1890 force-pushed the nri-socker-vol-mount branch 4 times, most recently from b2202bc to cb96419 Compare December 4, 2025 23:04
elezar
elezar reviewed Dec 5, 2025
View reviewed changes
@tariq1890 tariq1890 marked this pull request as draft December 5, 2025 16:31
@tariq1890 tariq1890 force-pushed the nri-socker-vol-mount branch 2 times, most recently from c5e1885 to 11982e7 Compare December 16, 2025 21:03
@tariq1890 tariq1890 force-pushed the nri-socker-vol-mount branch from 11982e7 to 436d854 Compare December 28, 2025 04:51
@tariq1890 tariq1890 force-pushed the nri-socker-vol-mount branch 11 times, most recently from f15f900 to 3435ba2 Compare January 16, 2026 01:09
@tariq1890 tariq1890 marked this pull request as ready for review January 16, 2026 01:12
@tariq1890 tariq1890 force-pushed the nri-socker-vol-mount branch from 3435ba2 to ed5c753 Compare January 16, 2026 01:18
cdesiniotis
cdesiniotis reviewed Jan 16, 2026
View reviewed changes
@tariq1890
[state-toolkit] add support for mounting runtime NRI sockets
d5d7f0a 
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>

add nri plugin annotation instead of setting nvidia runtimeclass

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@tariq1890 tariq1890 force-pushed the nri-socker-vol-mount branch from ed5c753 to d5d7f0a Compare January 16, 2026 21:50
@tariq1890 tariq1890 enabled auto-merge January 16, 2026 22:52
@tariq1890 tariq1890 merged commit d96bc1a into main Jan 16, 2026
17 checks passed
@tariq1890 tariq1890 deleted the nri-socker-vol-mount branch January 16, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elezar elezar elezar left review comments

@cdesiniotis cdesiniotis cdesiniotis approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@shivamerla shivamerla Awaiting requested review from shivamerla shivamerla is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tariq1890 @coveralls @elezar @cdesiniotis