fix(hostagent): minimize lock contention in NetworkManager#55
Draft
tsorya wants to merge 1 commit into
Draft
Conversation
run() and AddNetworkRequest() previously held the write lock across slow operations (API calls, PCI ops, netlink, network config), causing AddNetworkRequest HTTP handler to block for the entire run() cycle. Refactor to hold locks only for in-memory map operations: - run(): snapshot reqs under RLock, process lock-free - AddNetworkRequest(): RLock for map checks, no lock for API calls, brief Lock for map write - processNetworkRequest(): use removeRequest() helper for thread-safe map deletion Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run() and AddNetworkRequest() previously held the write lock across slow operations (API calls, PCI ops, netlink, network config), causing AddNetworkRequest HTTP handler to block for the entire run() cycle.
Refactor to hold locks only for in-memory map operations: