Skip to content

Fix find dense columns out of bounds #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Jan 24, 2026
+4 −2
Merged

Fix find dense columns out of bounds #793

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2f350e
Fix find dense columns out of bounds
hlinsen Jan 23, 2026
640a33f
Move assertion up
hlinsen Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/src/dual_simplex/barrier.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,9 +1121,10 @@ class iteration_data_t {
csr_matrix_t<i_t, f_t> A_row(0, 0, 0);
A.to_compressed_row(A_row);

std::vector<i_t> histogram(m, 0);
std::vector<i_t> histogram(m + 1, 0);
for (i_t j = 0; j < n; j++) {
const i_t col_nz_j = A.col_start[j + 1] - A.col_start[j];
cuopt_assert(col_nz_j <= m, "Column nonzero count exceeds histogram size");
histogram[col_nz_j]++;
}
#ifdef HISTOGRAM
Expand All @@ -1143,9 +1144,10 @@ class iteration_data_t {
}
}

std::vector<i_t> histogram_row(n, 0);
std::vector<i_t> histogram_row(n + 1, 0);
max_row_nz = 0;
for (i_t k = 0; k < m; k++) {
cuopt_assert(row_nz[k] <= n, "Row nonzero count exceeds histogram_row size");
histogram_row[row_nz[k]]++;
max_row_nz = std::max(max_row_nz, row_nz[k]);
}
Expand Down