Add cuOpt devcontainer configuration#1168
Open
bdice wants to merge 7 commits intoNVIDIA:mainfrom
Open
Conversation
bdice
added
feature request
bdice
commented
Apr 30, 2026
| uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@main | ||
| with: | ||
| arch: '["amd64", "arm64"]' | ||
| cuda: '["12.9", "13.1"]' |
Contributor
Author
There was a problem hiding this comment.
We only test one CUDA version for devcontainers in CI for other libraries. This is temporarily including 12.9 for testing, but we'll remove it before merging to keep CI runtime down.
Suggested change
| cuda: '["12.9", "13.1"]' | |
| cuda: '["13.1"]' |
|
Caution Review failedFailed to post review comments Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds devcontainer Dockerfile, README and four CUDA devcontainer configs; CI job to build/test in devcontainers and exclude devcontainer-only changes; extends release-version bumps to devcontainer files; updates test discovery/registration (rapids-test), CMake build/test wiring, small test fixes, and dataset extraction logic. ChangesDevcontainer + CI
Build / Test infrastructure & small fixes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.devcontainer/README.md:
- Line 34: The inline image tag lacks alt text, so update the <img> element in
the README line that shows the "Reopen in Container" screenshot to include a
descriptive alt attribute (e.g., alt="VS Code window with 'Reopen in Container'
button highlighted" or similar) so screen readers have context; locate the <img
src="https://user-images.githubusercontent.com/..."/> tag and add an appropriate
alt="..." value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7c6a2dc5-2800-49f1-ac8d-ec00eb6a7443
📒 Files selected for processing (8)
.devcontainer/Dockerfile.devcontainer/README.md.devcontainer/cuda12.9-conda/devcontainer.json.devcontainer/cuda12.9-pip/devcontainer.json.devcontainer/cuda13.1-conda/devcontainer.json.devcontainer/cuda13.1-pip/devcontainer.json.github/workflows/pr.yamlci/release/update-version.sh
trxcllnt
approved these changes
May 1, 2026
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@datasets/get_test_data.sh`:
- Around line 231-235: The archive extraction in the case handling for variable
tfname is swallowing failures with "|| true", which lets corrupt/unsupported
archives pass silently; update the extraction commands (the tar/unzip lines that
reference archive and DESTDIRS[$index]) to fail loudly instead of using "||
true"—either remove the "|| true" so the shell exits on error (ensure set -e is
enabled) or replace it with an explicit check that exits non‑zero (e.g., test
the command's return and call exit 1) so extraction errors propagate and stop
the script.
In `@python/cuopt/cuopt/linear_programming/CMakeLists.txt`:
- Around line 66-68: The set_property call for the TARGET mps_parser is using
the wrong argument order so APPEND is being treated as a value; update the
set_property invocation referencing target mps_parser and property INSTALL_RPATH
so the APPEND modifier appears before PROPERTY (i.e., use APPEND PROPERTY
INSTALL_RPATH ${rpaths}) to ensure rpaths are appended rather than replaced or
mis-parsed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: de8a2e28-4772-45df-bade-2f75ecf0778a
📒 Files selected for processing (8)
ci/run_ctests.shcpp/CMakeLists.txtcpp/libmps_parser/tests/CMakeLists.txtcpp/tests/CMakeLists.txtcpp/tests/linear_programming/CMakeLists.txtcpp/tests/linear_programming/grpc/CMakeLists.txtdatasets/get_test_data.shpython/cuopt/cuopt/linear_programming/CMakeLists.txt
✅ Files skipped from review due to trivial changes (1)
- cpp/libmps_parser/tests/CMakeLists.txt
Comment on lines
+231
to
+235
| case "${tfname}" in | ||
| *.tar.gz|*.tgz) tar xvzf "${archive}" -C "${DESTDIRS[$index]}" || true ;; | ||
| *.zip) unzip "${archive}" -d "${DESTDIRS[$index]}" || true ;; | ||
| *) tar xvf "${archive}" -C "${DESTDIRS[$index]}" || true ;; | ||
| esac |
There was a problem hiding this comment.
Propagate archive extraction failures.
Line 232-Line 234 still mask tar/unzip errors with || true. A corrupt or unsupported archive can leave partial dataset directories behind and let the script continue as if setup succeeded.
Suggested fix
- *.tar.gz|*.tgz) tar xvzf "${archive}" -C "${DESTDIRS[$index]}" || true ;;
- *.zip) unzip "${archive}" -d "${DESTDIRS[$index]}" || true ;;
- *) tar xvf "${archive}" -C "${DESTDIRS[$index]}" || true ;;
+ *.tar.gz|*.tgz) tar xvzf "${archive}" -C "${DESTDIRS[$index]}" ;;
+ *.zip) unzip "${archive}" -d "${DESTDIRS[$index]}" ;;
+ *) tar xvf "${archive}" -C "${DESTDIRS[$index]}" ;;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| case "${tfname}" in | |
| *.tar.gz|*.tgz) tar xvzf "${archive}" -C "${DESTDIRS[$index]}" || true ;; | |
| *.zip) unzip "${archive}" -d "${DESTDIRS[$index]}" || true ;; | |
| *) tar xvf "${archive}" -C "${DESTDIRS[$index]}" || true ;; | |
| esac | |
| case "${tfname}" in | |
| *.tar.gz|*.tgz) tar xvzf "${archive}" -C "${DESTDIRS[$index]}" ;; | |
| *.zip) unzip "${archive}" -d "${DESTDIRS[$index]}" ;; | |
| *) tar xvf "${archive}" -C "${DESTDIRS[$index]}" ;; | |
| esac |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@datasets/get_test_data.sh` around lines 231 - 235, The archive extraction in
the case handling for variable tfname is swallowing failures with "|| true",
which lets corrupt/unsupported archives pass silently; update the extraction
commands (the tar/unzip lines that reference archive and DESTDIRS[$index]) to
fail loudly instead of using "|| true"—either remove the "|| true" so the shell
exits on error (ensure set -e is enabled) or replace it with an explicit check
that exits non‑zero (e.g., test the command's return and call exit 1) so
extraction errors propagate and stop the script.
Comment on lines
+66
to
+68
| if(TARGET mps_parser) | ||
| set_property(TARGET mps_parser PROPERTY INSTALL_RPATH ${rpaths} APPEND) | ||
| endif() |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify incorrect set_property(APPEND) ordering in CMake files.
# Expected now: one match at python/cuopt/cuopt/linear_programming/CMakeLists.txt:67
# Expected after fix: zero matches.
rg -nP --type=cmake 'set_property\(\s*TARGET[\s\S]*?\bPROPERTY\b[\s\S]*?\bAPPEND\b' -g '**/CMakeLists.txt'Repository: NVIDIA/cuopt
Length of output: 505
Fix set_property argument order: APPEND must come before PROPERTY.
In CMake, the APPEND modifier must appear before the PROPERTY keyword, not after the property values. The current ordering may cause CMake to parse APPEND as a literal string value for INSTALL_RPATH, breaking the intended append behavior.
Suggested fix
if(TARGET mps_parser)
- set_property(TARGET mps_parser PROPERTY INSTALL_RPATH ${rpaths} APPEND)
+ set_property(TARGET mps_parser APPEND PROPERTY INSTALL_RPATH ${rpaths})
endif()📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if(TARGET mps_parser) | |
| set_property(TARGET mps_parser PROPERTY INSTALL_RPATH ${rpaths} APPEND) | |
| endif() | |
| if(TARGET mps_parser) | |
| set_property(TARGET mps_parser APPEND PROPERTY INSTALL_RPATH ${rpaths}) | |
| endif() |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@python/cuopt/cuopt/linear_programming/CMakeLists.txt` around lines 66 - 68,
The set_property call for the TARGET mps_parser is using the wrong argument
order so APPEND is being treated as a value; update the set_property invocation
referencing target mps_parser and property INSTALL_RPATH so the APPEND modifier
appears before PROPERTY (i.e., use APPEND PROPERTY INSTALL_RPATH ${rpaths}) to
ensure rpaths are appended rather than replaced or mis-parsed.
| with: | ||
| build_type: pull-request | ||
| script: ci/test_self_hosted_service.sh | ||
| devcontainer: |
Collaborator
There was a problem hiding this comment.
Is it possible to skip devcontainer build if there no changes required for the build or test ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary