refactor(pathfinder): unify dynamic-lib subprocess probing (production, test code)#1779
Draft
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Draft
refactor(pathfinder): unify dynamic-lib subprocess probing (production, test code)#1779rwgk wants to merge 1 commit intoNVIDIA:mainfrom
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
f8dc41c to
0e1b49e
Compare
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Consolidate canary and test subprocess entrypoints behind a shared module and JSON payload, update call sites/tests accordingly, and remove the old test-only subprocess helpers. Made-with: Cursor
0e1b49e to
776e53c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1771
Follow-on to PR #1777
Special attention was paid to:
Suggested review path that minimizes context switching:
Production flow first
Focus: payload schema (status, abs_path), parsing errors, command builder.
Focus: canary vs load mode behavior, JSON output, abs_path validation.
Focus: canary subprocess invocation, timeout/error handling, JSON parsing.
Test and helper flow
Focus: command invocation, neutral cwd, JSON parsing.
Focus: subprocess command args and payload expectations.
Focus: updated canary probe payload/command expectations.
Focus: not-found handling and parsed abs_path.
Focus: not-found handling and parsed abs_path.
Focus: lint allowlist path updated.
Made with Cursor