-
Notifications
You must be signed in to change notification settings - Fork 49
Add UCC/NCCL alltoallv, deepEP v1/v2 and moe benchmark #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ybenvidia
wants to merge
9
commits into
NVIDIA:main
Choose a base branch
from
ybenvidia:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e912a9c
add tuning option
ybenvidia aee7ebb
Merge branch 'NVIDIA:main' into dp-benchmark
ybenvidia ed01ea8
Merge branch 'NVIDIA:main' into dp-benchmark
ybenvidia 8b029c9
Merge branch 'NVIDIA:main' into dp-benchmark
ybenvidia 1b85a6e
add ucc/nccl all2allv
ybenvidia 12f6742
Merge branch 'NVIDIA:main' into dp-benchmark
ybenvidia 3a743d3
Merge branch 'NVIDIA:main' into main
ybenvidia 72a6f84
add deepep v1/v2 and first version of the moe-benchmark
ybenvidia f81856e
fix pytest
ybenvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,6 +87,7 @@ ehthumbs.db | |
| Thumbs.db | ||
|
|
||
| *.log | ||
| slurm-* | ||
| install/ | ||
| results/ | ||
| .* | ||
|
|
||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name = "deepep_test_ep_v2" | ||
| description = "Official DeepEP V2 elastic test_ep" | ||
| test_template_name = "DeepEP" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "/your/path/to/the/container" | ||
| subtest_name = "test_ep" | ||
| elastic_tests_root = "/path/in/the/container/to/the/tests/folder" | ||
| num_processes = 8 | ||
| num_sms = 0 | ||
| num_qps = 0 | ||
| num_allocated_qps = 0 | ||
| num_tokens = 4096 | ||
| hidden = 7168 | ||
| num_topk = 8 | ||
| num_experts = 256 | ||
| do_cpu_sync = 1 | ||
| allow_hybrid_mode = 1 | ||
| allow_multiple_reduction = 1 | ||
| prefer_overlap_with_compute = 0 | ||
| seed = 0 | ||
| skip_check = false | ||
| skip_perf_test = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name = "deepep_test_internode" | ||
| description = "Official DeepEP V1 legacy test_internode" | ||
| test_template_name = "DeepEP" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "/your/path/to/the/container" | ||
| subtest_name = "test_internode" | ||
| legacy_tests_root = "/path/in/the/container/to/the/tests/folder" | ||
| num_processes = 8 | ||
| num_tokens = 4096 | ||
| hidden = 7168 | ||
| num_topk = 8 | ||
| num_experts = 256 | ||
| pressure_test_mode = 0 | ||
| test_ll_compatibility = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name = "deepep_test_intranode" | ||
| description = "Official DeepEP V1 legacy test_intranode" | ||
| test_template_name = "DeepEP" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "/your/path/to/the/container" | ||
| subtest_name = "test_intranode" | ||
| legacy_tests_root = "/path/in/the/container/to/the/tests/folder" | ||
| num_processes = 8 | ||
| num_tokens = 4096 | ||
| hidden = 7168 | ||
| num_topk = 8 | ||
| num_experts = 256 | ||
| allow_mnnvl = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name = "deepep_test_low_latency" | ||
| description = "Official DeepEP V1 legacy test_low_latency" | ||
| test_template_name = "DeepEP" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "/your/path/to/the/container" | ||
| subtest_name = "test_low_latency" | ||
| legacy_tests_root = "/path/in/the/container/to/the/tests/folder" | ||
| num_processes = 8 | ||
| num_tokens = 128 | ||
| hidden = 7168 | ||
| num_topk = 8 | ||
| num_experts = 288 | ||
| allow_mnnvl = false | ||
| disable_nvlink = false | ||
| use_logfmt = false | ||
| pressure_test = false | ||
| shrink_test = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name = "moe_benchmark_low_latency" | ||
| description = "MoE Benchmark - DeepEP low-latency mode plus matrix export" | ||
| test_template_name = "MoEBenchmark" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "/your/path/to/the/container" | ||
| benchmark_root = "/path/in/the/container/to/the/tests/folder" | ||
| mode = "low_latency" | ||
| tokens = 128 | ||
| num_experts = 288 | ||
| num_topk = 8 | ||
| hidden_size = 7168 | ||
| data_type = "bfloat16" | ||
| allow_nvlink_for_low_latency = false | ||
| allow_mnnvl = false | ||
| round_scale = false | ||
| use_ue8m0 = false | ||
| num_warmups = 20 | ||
| num_iterations = 50 | ||
| shuffle_columns = false | ||
| use_kineto_profiler = false | ||
| enable_tuning = false | ||
| config_file_path = "/tmp/config.yaml" | ||
| results_dir = "/workspace/dp-benchmark/results" | ||
|
|
||
| [extra_env_vars] | ||
| NUM_QPS_PER_RANK = "12" | ||
| NUM_SMS = "24" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name = "moe_benchmark_standard" | ||
| description = "MoE Benchmark - DeepEP standard mode plus matrix export" | ||
| test_template_name = "MoEBenchmark" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "/your/path/to/the/container" | ||
| benchmark_root = "/workspace/dp-benchmark/benchmark" | ||
| mode = "standard" | ||
| tokens = 4096 | ||
| num_experts = 256 | ||
| num_topk = 8 | ||
| hidden_size = 7168 | ||
| data_type = "bfloat16" | ||
| allow_nvlink_for_low_latency = false | ||
| allow_mnnvl = false | ||
| round_scale = false | ||
| use_ue8m0 = false | ||
| num_warmups = 20 | ||
| num_iterations = 50 | ||
| shuffle_columns = false | ||
| use_kineto_profiler = false | ||
| enable_tuning = false | ||
| config_file_path = "/tmp/config.yaml" | ||
| results_dir = "/workspace/dp-benchmark/results" | ||
|
|
||
| [extra_env_vars] | ||
| NUM_QPS_PER_RANK = "12" | ||
| NUM_SMS = "24" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "ucc_alltoallv_deepep" | ||
| description = "UCC AlltoAllv" | ||
| test_template_name = "UCCTest" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "/your/path/to/the/container" | ||
| collective = "alltoallv" | ||
| b = 1 | ||
| e = "8M" | ||
| use_deepep_matrix = true | ||
|
|
||
| [extra_env_vars] | ||
| UCX_IB_GID_INDEX = "auto" | ||
| UCX_TLS = "cuda_copy,rc" | ||
| UCX_RNDV_THRESH = "0" | ||
| UCX_RNDV_SCHEME = "get_zcopy" | ||
| MELLANOX_VISIBLE_DEVICES = "0,3,4,5,6,9,10,11" | ||
| CUDA_VISIBLE_DEVICES = "0,1,2,3,4,5,6,7" | ||
| UCC_CL_HIER_FULL_SBGP_TLS = "ucp" | ||
| UCC_CL_HIER_NODE_SBGP_TLS = "cuda" | ||
| UCC_TLS = "ucp,cuda" | ||
| UCC_CL_HIER_TUNE = "alltoallv:0-inf:@node_split" | ||
| UCC_TL_UCP_ALLTOALLV_PAIRWISE_NUM_POSTS = "8" | ||
| UCC_CLS = "basic,hier" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name = "deepep-official-tests" | ||
|
|
||
| [[Tests]] | ||
| id = "Tests.deepep_test_internode" | ||
| test_name = "deepep_test_internode" | ||
| num_nodes = 2 | ||
| time_limit = "00:30:00" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name = "moe-benchmark" | ||
|
|
||
| [[Tests]] | ||
| id = "Tests.moe_benchmark" | ||
| test_name = "moe_benchmark_standard" | ||
| num_nodes = 2 | ||
| time_limit = "00:30:00" | ||
|
|
||
| [[Tests]] | ||
| id = "Tests.ucc_alltoallv" | ||
| test_name = "ucc_alltoallv_deepep" | ||
| num_nodes = 2 | ||
| time_limit = "00:30:00" | ||
| [[Tests.dependencies]] | ||
| type = "start_post_comp" | ||
| id = "Tests.moe_benchmark" | ||
|
|
||
| [[Tests]] | ||
| id = "Tests.nccl_alltoallv" | ||
| test_name = "nccl_test_alltoallv" | ||
| num_nodes = 2 | ||
| time_limit = "00:30:00" | ||
| [[Tests.dependencies]] | ||
| type = "start_post_comp" | ||
| id = "Tests.ucc_alltoallv" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | ⚖️ Poor tradeoff
Verify the dependency chain design: serial vs. parallel execution.
The current configuration chains tests serially:
moe_benchmark→ucc_alltoallv→nccl_alltoallv. This means NCCL test waits for UCC test to complete, even though both tests independently consume matrices from the MoE benchmark output (as indicated by layers 10 and 12 in the stack context).If both UCC and NCCL tests only need the MoE benchmark output and don't depend on each other, consider having both depend directly on
Tests.moe_benchmark:This would allow UCC and NCCL tests to run in parallel after MoE benchmark completes, reducing total scenario runtime. The current serial chain may be intentional for resource management or debugging—please confirm this design choice.
🤖 Prompt for AI Agents