[None][perf] Skip transceiver tp_allgather when no sessions ever opened#14042
Open
Shixiaowei02 wants to merge 1 commit into
Open
[None][perf] Skip transceiver tp_allgather when no sessions ever opened#14042Shixiaowei02 wants to merge 1 commit into
Shixiaowei02 wants to merge 1 commit into
Conversation
64791f5 to
684e049
Compare
liji-nv
approved these changes
May 12, 2026
qiaoxj07
approved these changes
May 12, 2026
chuangz0
approved these changes
May 12, 2026
Signed-off-by: Xiaowei Shi <39303645+Shixiaowei02@users.noreply.github.com>
684e049 to
70162aa
Compare
Collaborator
Author
|
/bot run --add-multi-gpu-test --disable-fail-fast |
Collaborator
|
PR_Github #47973 [ run ] triggered by Bot. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
V4-Pro 8k/1k MTP3 disagg (ctx1 TP=4 + gen4 TP=8), concurrency=4/server (total 16), 128 prompts × 8 rounds, gb300:
GPU compute is unchanged . The full 4.4% e2e throughput win comes from eliminating one
tp_allgatherper decode iter on the GEN worker, which had previously synced all 8 TP ranks every iter against an empty consensus list.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.