[None][fix] fix warm up number in disagg benchmark

[chuangz0]

Summary by CodeRabbit

• Chores
  • Updated benchmark configuration calculation for improved performance tuning in distributed scenarios.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

[chuangz0]

/bot run --disable-fail-fast

[coderabbitai]

📝 Walkthrough

Walkthrough

The change updates the UCX warmup request calculation in a disaggregated benchmark submission script. The computation shifts from using world sizes to using the number of nodes multiplied by data parallelism factors derived from attention data parallelism configuration flags.

Changes

UCX Warmup Request Calculation

Layer / File(s)	Summary
UCX warmup request calculation update examples/disaggregated/slurm/benchmark/submit.py	ctx_dp_size and gen_dp_size are derived from enable_attention_dp flags in worker_config, then used to compute ucx_warmup_requests as 2 * ctx_num * ctx_dp_size * gen_num * gen_dp_size for e2e mode, or 0 otherwise.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is entirely composed of the template with all sections empty, including the required 'Description' and 'Test Coverage' sections that explain what and why.	Fill in the 'Description' section explaining the issue and solution, and the 'Test Coverage' section listing relevant tests that validate the warm-up number fix.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the fix: correcting the warm-up number calculation in the disaggregated benchmark submission script.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

examples/disaggregated/slurm/benchmark/submit.py (1)

1-1: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add/update the NVIDIA copyright header for this modified file.

This file was modified but does not include the required NVIDIA header with the current modification year.

As per coding guidelines: **/*.{cpp,h,hpp,cu,cuh,py}: All C++, Python, and other source files must contain NVIDIA copyright header with current modification year.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/disaggregated/slurm/benchmark/submit.py` at line 1, Add or update
the NVIDIA copyright header at the top of submit.py (above the existing shebang
or immediately below it) to include the required NVIDIA header text with the
current modification year; ensure the header matches the project's required
format for Python files and replaces or augments any existing header lines so
the file complies with the codebase rule for "*.{cpp,h,hpp,cu,cuh,py}".

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@examples/disaggregated/slurm/benchmark/submit.py`:
- Line 1: Add or update the NVIDIA copyright header at the top of submit.py
(above the existing shebang or immediately below it) to include the required
NVIDIA header text with the current modification year; ensure the header matches
the project's required format for Python files and replaces or augments any
existing header lines so the file complies with the codebase rule for
"*.{cpp,h,hpp,cu,cuh,py}".

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 82b23e95-b425-4db8-8a87-604430a85836

📥 Commits

Reviewing files that changed from the base of the PR and between 7bc328f and 61996ff.

📒 Files selected for processing (1)

• examples/disaggregated/slurm/benchmark/submit.py

[tensorrt-cicd]

PR_Github #47936 [ run ] triggered by Bot. Commit: 61996ff Link to invocation