[https://nvbugs/6162128] Remove nano v3 E2E test#14036
Open
2ez4bz wants to merge 1 commit into
Open
Conversation
Tests in `tests/integration/test_lists/qa/llm_function_core.txt` may run on unintended GPU SKUs, leading to false positive blanket waive entries in `tests/integration/test_lists/waives.txt`. This commit removes the E2E accuracy tests for Nano V3 Omni so as to unblock testing on actual SKUs of interest (H100, B200). Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
Collaborator
Author
|
/bot run |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR updates the QA test suite by removing deprecated NanoV3Omni auto-dtype tests and adding new multimodal test entries for MistralLarge3, MistralSmall24B, and Nemotron models, while removing their corresponding waiver entries. ChangesTest List Maintenance
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
xinhe-nv
reviewed
May 12, 2026
| accuracy/test_llm_api_pytorch_multimodal.py::TestMistralLarge3_675B::test_nvfp4_4gpus[latency_moe_trtllm] | ||
| accuracy/test_llm_api_pytorch_multimodal.py::TestMistralSmall24B::test_auto_dtype[forced_chunked_prefill] | ||
| accuracy/test_llm_api_pytorch_multimodal.py::TestNemotron_Nano_12B_V2_VL::test_auto_dtype[forced_chunked_prefill] | ||
| accuracy/test_llm_api_pytorch_multimodal.py::TestNanoV3Omni::test_auto_dtype[bf16] |
Collaborator
There was a problem hiding this comment.
if you don't want to run these tests on GB300, please add pytest.mark for the test definition. refer to other tests.
Collaborator
|
PR_Github #47918 [ run ] triggered by Bot. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Description
Tests in
tests/integration/test_lists/qa/llm_function_core.txtmay run on unintended GPU SKUs, leading to false positive blanket waive entries intests/integration/test_lists/waives.txt.This commit removes the E2E accuracy tests for Nano V3 Omni so as to unblock testing on actual SKUs of interest (H100, B200).
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.