Skip to content

[None][fix] Unwaive standalone llm-c package generation test#14011

Open
bmarimuthu-nv wants to merge 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:bala/ad-transformations-unwaive
Open

[None][fix] Unwaive standalone llm-c package generation test#14011
bmarimuthu-nv wants to merge 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:bala/ad-transformations-unwaive

Conversation

@bmarimuthu-nv
Copy link
Copy Markdown
Collaborator

@bmarimuthu-nv bmarimuthu-nv commented May 11, 2026

Summary by CodeRabbit

  • Chores
    • Refined standalone package generation by excluding additional test modules to streamline deployment packages.
    • Removed an outdated test waiver entry from the testing framework.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
@bmarimuthu-nv
Copy link
Copy Markdown
Collaborator Author

@CodeRabbit summary

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

✅ Actions performed

Summary regeneration triggered.

@bmarimuthu-nv
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@bmarimuthu-nv bmarimuthu-nv marked this pull request as ready for review May 11, 2026 22:40
@bmarimuthu-nv bmarimuthu-nv requested a review from a team as a code owner May 11, 2026 22:40
@bmarimuthu-nv bmarimuthu-nv changed the title [None][fix] Unwauve standalone llm-c package generation test [None][fix] Unwaive standalone llm-c package generation test May 11, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4c4862ae-5a0b-4ad3-ba24-5ed75137e683

📥 Commits

Reviewing files that changed from the base of the PR and between e197b69 and 9536716.

📒 Files selected for processing (2)
  • examples/auto_deploy/llmc/create_standalone_package.py
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

The PR updates test configuration across two files: the standalone package generator now excludes two additional quant-fusion-related test files, and a previously-skipped transformation test is removed from the waives list.

Changes

Test Configuration Updates

Layer / File(s) Summary
Standalone Package Test Exclusions
examples/auto_deploy/llmc/create_standalone_package.py
EXCLUDE_TEST_FILES set extended with test_quant_fusion.py and test_finegrained_fp8_swiglu.py to exclude quant-fusion tests from the copied standalone package tests directory.
Test Waiver Removal
tests/integration/test_lists/waives.txt
Waiver entry for unittest/auto_deploy/singlegpu/transformations (marked SKIP) is removed from the integration test waivers list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely the repository template with no substantive content filled in for Description, Test Coverage, or relevant implementation details. Fill in the Description section explaining the issue and solution, and the Test Coverage section listing relevant tests that validate the changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: unwaiving a previously skipped standalone llm-c package generation test by removing a waiver entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47797 [ run ] triggered by Bot. Commit: 9536716 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47797 [ run ] completed with state SUCCESS. Commit: 9536716
/LLM/main/L0_MergeRequest_PR pipeline #37688 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@suyoggupta
Copy link
Copy Markdown
Collaborator

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47869 [ run ] triggered by Bot. Commit: 0816c69 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47869 [ run ] completed with state SUCCESS. Commit: 0816c69
/LLM/main/L0_MergeRequest_PR pipeline #37732 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants