[None][fix] Run DeepSeek V4 gate test on CUDA#13932
Open
lfr-0531 wants to merge 1 commit intoNVIDIA:feat/deepseek_v4from
Open
[None][fix] Run DeepSeek V4 gate test on CUDA#13932lfr-0531 wants to merge 1 commit intoNVIDIA:feat/deepseek_v4from
lfr-0531 wants to merge 1 commit intoNVIDIA:feat/deepseek_v4from
Conversation
Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
Collaborator
Author
|
/bot run --add-multi-gpu-test |
longlee0622
approved these changes
May 9, 2026
Collaborator
|
PR_Github #47482 [ run ] triggered by Bot. Commit: |
Shixiaowei02
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
The DeepSeek V4 gate unit test was added to the multi-GPU CI test list, where it exposed that
test_deepseek_v4_gate_uses_fp32_reference_linearconstructed the gate and input tensors on CPU.DeepseekV4Gate.forward()callstrtllm::dsv3_router_gemm_op, which is a CUDA-only custom op. This caused the B200 multi-GPU stage to fail with a CPU backend dispatch error.This PR updates the test to run the gate, hidden states, and reference weights on CUDA, and skips the test when CUDA is unavailable.
Test Coverage
python3 -m pytest -q tests/unittest/_torch/modeling/test_modeling_deepseekv4.py::test_deepseek_v4_gate_uses_fp32_reference_linearpython3 -m pytest -q tests/unittest/_torch/modeling/test_modeling_deepseekv4.pypre-commit run --files tests/unittest/_torch/modeling/test_modeling_deepseekv4.pyPR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.